Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

template: custom change_mode scripts #13972

Merged
merged 71 commits into from
Aug 24, 2022
Merged

template: custom change_mode scripts #13972

merged 71 commits into from
Aug 24, 2022

Conversation

pkazmierczak
Copy link
Contributor

@pkazmierczak pkazmierczak commented Aug 3, 2022 •
edited
Loading

This PR adds the functionality of allowing custom scripts to be executed on template change. Resolves #2707

@pkazmierczak pkazmierczak force-pushed the f-nomad-template-custom-change-mode branch from 92f233d to 03e6dab Compare August 4, 2022 09:23
pkazmierczak and others added 2 commits August 9, 2022 09:59
@pkazmierczak
corrections
ae15843
@pkazmierczak @DerekStrickland
revamped tests
f9b12c6 
Co-authored-by: Derek Strickland <DerekStrickland@users.noreply.github.com>
lgfa29
lgfa29 suggested changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to get those duplicate events fixed and we're good to go 😄

client/allocrunner/tasklifecycle/doc.go Outdated Show resolved Hide resolved
client/allocrunner/taskrunner/template/template.go Show resolved Hide resolved
client/allocrunner/taskrunner/template/template.go Outdated Show resolved Hide resolved
website/content/api-docs/json-jobs.mdx Outdated Show resolved Hide resolved
website/content/docs/job-specification/change_script.mdx Outdated Show resolved Hide resolved
@lgfa29 lgfa29 added this to the 1.3.4 milestone Aug 24, 2022
@pkazmierczak @lgfa29
Apply suggestions from code review
b77da29 
Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>
pkazmierczak and others added 2 commits August 24, 2022 10:18
@pkazmierczak @lgfa29
Update website/content/api-docs/json-jobs.mdx
0a1b5d7 
Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>
@pkazmierczak
formatting
88993bb
lgfa29
lgfa29 approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@pkazmierczak pkazmierczak merged commit 34e4b08 into main Aug 24, 2022
@pkazmierczak pkazmierczak deleted the f-nomad-template-custom-change-mode branch August 24, 2022 15:43
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Aug 24, 2022
Merged
pkazmierczak added a commit that referenced this pull request Aug 24, 2022
@pkazmierczak
template: custom change_mode scripts (#13972)
d3ce4cc 
This PR adds the functionality of allowing custom scripts to be executed on template change. Resolves #2707
pkazmierczak pushed a commit that referenced this pull request Aug 24, 2022
@hc-github-team-nomad-core
Backport of template: custom change_mode scripts into release/1.3.x (#…
0453098 
…14294)

* template: custom change_mode scripts (#13972)

This PR adds the functionality of allowing custom scripts to be executed on template change. Resolves #2707
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lgfa29 lgfa29 lgfa29 approved these changes

@DerekStrickland DerekStrickland DerekStrickland approved these changes

@jrasell jrasell jrasell approved these changes

Assignees

@pkazmierczak pkazmierczak

Labels
backport/1.3.x backport to 1.3.x release line theme/template
Projects
None yet
Milestone
1.3.4
Development

Successfully merging this pull request may close these issues.

Nomad template custom change_mode
5 participants
@pkazmierczak @hashicorp-cla @lgfa29 @DerekStrickland @jrasell