allow unhealthy canaries without blocking autopromote #14001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgfa29
approved these changes
Aug 4, 2022
There was a problem hiding this comment.
Thanks for the PR @chuckyz!
The tests look great, I just pushed a commit a simplify it a little. This bug didn't seem to happen with rolling updates (only canary), so I removed them from the tests.
I also pushed a changelog entry for this change.
lgfa29
added
backport/1.1.x
This was referenced Aug 4, 2022
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8150
One thing I'm not 100% about this is if the test is correct. If I'm reading everything from copy/pasting the other one and understanding the data model this should "just work," because we're never setting
c3to healthy, so that should test this exact bit of logic (where we want 2 healthy canaries, have 3 placed, and only 2 are ever promoted to healthy).