Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a log line to help track node eligibility #14125

Merged
merged 4 commits into from
Sep 6, 2022

Conversation

Kellel
Copy link
Contributor

@Kellel Kellel commented Aug 15, 2022

Often when debugging issues with our nomad cluster we find that it can
be difficult to correlate manual and automated actions against the
cluster state as nodes are brought into and out of production.

This doesn't fix #8965, but it is something to help minimize the inconvenience in the meantime.

@hashicorp-cla
Copy link

hashicorp-cla commented Aug 15, 2022

CLA assistant check
All committers have signed the CLA.

Often when debugging issues with our nomad cluster we find that it can
be difficult to correlate manual and automated actions against the
cluster state as nodes are brought into and out of production.
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Kellel and thanks for raising this PR which seems very useful to cluster operators. I have suggested some changes for you to look over; the most notable change is to remove the use of .With from the logger. This function creates a sublogger with the given kv context always present which we do not need. We can just rely on the message kv formatting for this use case.

nomad/node_endpoint.go Outdated Show resolved Hide resolved
nomad/node_endpoint.go Outdated Show resolved Hide resolved
nomad/node_endpoint.go Outdated Show resolved Hide resolved
Co-authored-by: James Rasell <jrasell@users.noreply.github.com>
@Kellel
Copy link
Contributor Author

Kellel commented Aug 22, 2022

Anything else needed here @jrasell ?

@Kellel Kellel requested a review from jrasell September 2, 2022 21:58
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Kellel thanks for this; I just added a changelog entry and will get this merged.

@jrasell jrasell added this to the 1.4.0 milestone Sep 6, 2022
@jrasell jrasell merged commit 08de94b into hashicorp:main Sep 6, 2022
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metric label node_scheduling_availability does not update with changes.
3 participants