-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a log line to help track node eligibility #14125
Conversation
Often when debugging issues with our nomad cluster we find that it can be difficult to correlate manual and automated actions against the cluster state as nodes are brought into and out of production.
3f33c67
to
694d560
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Kellel and thanks for raising this PR which seems very useful to cluster operators. I have suggested some changes for you to look over; the most notable change is to remove the use of .With
from the logger. This function creates a sublogger with the given kv context always present which we do not need. We can just rely on the message kv formatting for this use case.
Co-authored-by: James Rasell <jrasell@users.noreply.github.com>
Anything else needed here @jrasell ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Kellel thanks for this; I just added a changelog entry and will get this merged.
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Often when debugging issues with our nomad cluster we find that it can
be difficult to correlate manual and automated actions against the
cluster state as nodes are brought into and out of production.
This doesn't fix #8965, but it is something to help minimize the inconvenience in the meantime.