template: use pointer values for gid and uid #14203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a Nomad agent starts and loads jobs that already existed in the cluster, the default template uid and gid was being set to 0, since this is the zero value for int. This caused these jobs to fail in environments where it was not possible to use 0, such as in Windows clients. In order to differentiate between an explicit 0 and a template where these properties were not set we need to use a pointer.
tgross
approved these changes
Aug 22, 2022
Comment on lines
87
to
88
| - `uid` `(int: nil)` - Specifies the rendered template owner's user ID. Negative | ||
| values will use the ID of the Nomad agent user. |
There was a problem hiding this comment.
If we're changing this default to nil we should document what nil does too.
.changelog/14203.txt
Outdated
| @@ -0,0 +1,3 @@ | |||
| ```release-note:bug | |||
| template: Fixed a bug where job templates would use `uid` and `gid` 0 after upgrading to Nomad 1.3.3 | |||
There was a problem hiding this comment.
I feel like we should probably also document the Windows-specific error behavior here?
lgfa29
added a commit
that referenced
this pull request
Aug 22, 2022
When a Nomad agent starts and loads jobs that already existed in the cluster, the default template uid and gid was being set to 0, since this is the zero value for int. This caused these jobs to fail in environments where it was not possible to use 0, such as in Windows clients. In order to differentiate between an explicit 0 and a template where these properties were not set we need to use a pointer.
lgfa29
added a commit
that referenced
this pull request
Aug 22, 2022
When a Nomad agent starts and loads jobs that already existed in the cluster, the default template uid and gid was being set to 0, since this is the zero value for int. This caused these jobs to fail in environments where it was not possible to use 0, such as in Windows clients. In order to differentiate between an explicit 0 and a template where these properties were not set we need to use a pointer. Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Nomad agent starts and loads jobs that already existed in the
cluster, the default template
uidandgidwas being set to0, since thisis the zero value for
int. This caused these jobs to fail inenvironments where it was not possible to use
0, such as in Windowsclients.
In order to differentiate between an explicit
0and atemplatewherethese properties were not set we need to use a pointer.
Closes #14085