Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update upgrade guide to reflect enterprise changes introduced in nomad-enterprise #14212

Merged
merged 2 commits into from
Aug 24, 2022

Conversation

pkazmierczak
Copy link
Contributor

@pkazmierczak pkazmierczak commented Aug 22, 2022

This PR documents a change made in the enterprise version of nomad that addresses the following issue:

Issue

When a user tries to filter audit logs, they do so with a stanza that looks like the following:

audit {
  enabled = true

  filter "remove deletes" {
    type = "HTTPEvent"
    endpoints  = ["*"]
    stages = ["OperationComplete"]
    operations = ["DELETE"]
  }
}

When specifying both an "endpoint" and a "stage", the events with both matching a "endpoint" AND a matching "stage" will be filtered.

When specifying both an "endpoint" and an "operation" the events with both matching a "endpoint" AND a matching "operation" will be filtered.

When specifying both a "stage" and an "operation" the events with a matching a "stage" OR a matching "operation" will be filtered.

The "OR" logic with stages and operations is unexpected and doesn't allow customers to get specific on which events they want to filter. For instance the following use-case is impossible to achieve: "I want to filter out all OperationReceived events that have the DELETE verb".

@pkazmierczak pkazmierczak self-assigned this Aug 22, 2022
@pkazmierczak pkazmierczak changed the title documentation: Update upgrade guide to reflect enterprise changes introduced in nomad-enterprise docs: Update upgrade guide to reflect enterprise changes introduced in nomad-enterprise Aug 22, 2022
Copy link
Contributor

@DerekStrickland DerekStrickland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to fix the Nomad version. This will go out in 1.4.0 since it's a breaking change 👍

website/content/docs/upgrade/upgrade-specific.mdx Outdated Show resolved Hide resolved
website/content/docs/upgrade/upgrade-specific.mdx Outdated Show resolved Hide resolved
@github-actions
Copy link

Ember Asset Size action

As of 36bea82

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +20 B -10 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

Ember Test Audit comparison

main 36bea82 change
passes 1410 1410 0
failures 0 0 0
flaky 0 0 0
duration 10m 14s 637ms 12m 02s 819ms +1m 48s 182ms

@lgfa29 lgfa29 removed the backport/1.3.x backport to 1.3.x release line label Aug 24, 2022
lgfa29 added a commit that referenced this pull request Aug 24, 2022
lgfa29 added a commit that referenced this pull request Aug 24, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants