build: set osusergo build tag by default #14248
Conversation
This PR activates the osuergo build tag in GNUMakefile. This forces the os/user
package to be compiled without CGO. Doing so seems to resolve a race condition
in getpwnam_r that causes alloc creation to hang or panic on `user.Lookup("nobody")`.
shoenig
force-pushed
the
b-set-osusergo
branch
from
1bf157b
to
c4ec30a
Compare
|
Is this an issue in previous versions as well? How far back should we backport it? 🤔 |
We saw it in 1.2.6 (ref #12342) but didn't have a repro at the time. As far as I can tell the problem is inherent to the design (concurrent lookups b/c we start tasks concurrently), not to a specific version. We should probably backport to all supported versions. |
shoenig
added
backport/1.1.x
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR activates the osuergo build tag in GNUMakefile. This forces the os/user
package to be compiled without CGO. Doing so seems to resolve a race condition
in
getpwnam_rthat causes alloc creation to hang or panic onuser.Lookup("nobody").Fixes: #14235
Fixes: #14217