Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Namespace, Job and Group to envoy stats #14311

Merged
merged 4 commits into from
Sep 22, 2022

Conversation

jorgemarey
Copy link
Contributor

@jorgemarey jorgemarey commented Aug 24, 2022

This PR adds more tags (nomad namespace, job and group) to the envoy stats tags.
It's useful when performing scaling based on envoy request being able to filter the service by nomad job/group.

Follows the work done in #12543

client/serviceregistration/workload.go Outdated Show resolved Hide resolved
command/agent/consul/connect.go Outdated Show resolved Hide resolved
command/agent/consul/connect.go Outdated Show resolved Hide resolved
@tgross
Copy link
Member

tgross commented Aug 25, 2022

Thanks for the PR @jorgemarey! I've left some comments for discussion.

@jorgemarey
Copy link
Contributor Author

Thanks @tgross for taking the time to review this. I'll update the PR with the suggested changes as soon as I can!

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jorgemarey! Thanks for your patience on this. The updates you've done here LGTM 👍 . I'm going to push a changelog entry on top of the PR, rebase on main, and fix the merge conflicts and then we'll get this merged.

@vercel
Copy link

vercel bot commented Sep 22, 2022

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

@tgross
Copy link
Member

tgross commented Sep 22, 2022

Merged! This will ship in Nomad 1.4.0

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants