Sanitize empty slices/maps in Jobs #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| func (n *NetworkResource) InitFields() { | ||
| // Ensure that an empty and nil slices are treated the same to avoid scheduling | ||
| // problems since we use reflect DeepEquals. | ||
| if len(n.ReservedPorts) == 0 && n.ReservedPorts != nil { |
There was a problem hiding this comment.
len(n.ReserverPorts) == 0 should suffice since len of empty and nil slice is 0
|
LGTM, but I don't see a reason to remove the call to |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sanitizes empty slices/maps in jobs to be treated as nil internally. This avoids the problem of a user submitting a job once with
env: {}and once withenv: nulland having a destructive update take place.