Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many UI bugs in v1.3.4 #14359

Closed
iluminae opened this issue Aug 27, 2022 · 19 comments
Closed

Many UI bugs in v1.3.4 #14359

iluminae opened this issue Aug 27, 2022 · 19 comments

Comments

@iluminae
Copy link

iluminae commented Aug 27, 2022

Nomad version

Nomad v1.3.4 (a267b2b)

Operating system and Environment details

Linux [arm,arm64,amd64]
ACLs are not enabled

Issue

I will try to enumerate all the issues here, but the UI is very broken in v1.3.4.

  • Any graph is blank and spams the browser console with errors. They all seem to be like this error: Uncaught Error: TypeError: Cannot read properties of null (reading 'then')
  • going to the Files tab of any allocation or task will completely crash the page with UNRECOVERABLE ERROR: TypeError: Cannot read properties of null (reading 'then')
  • going to the Logs tab of any task results in a blank log box and this error: Uncaught TypeError: Cannot read properties of null (reading 'body')
  • going to a client, the eligible and drain options are greyed out. This cluster has no ACLs enabled, so these should be available.

Reproduction steps

I am not sure if it is environment or browser specific at all, but I am using Chrome 105.0.5195.42

Expected Result

the graphs, logs, files features of the ui to... work.

Actual Result

the graphs, logs, files features of the ui do not.... work.

Job file (if appropriate)

n/a

@philrenaud
Copy link
Contributor

Hi @iluminae, thanks for raising this. Digging into it now. To help me isolate the problem more quickly, do you happen to know the most recent version of Nomad you were using without the aforementioned UI errors?

@iluminae
Copy link
Author

v1.3.3 - and I kept one client back at that version so I can use it's UI. (all of the features work fine on there, including clients -> eligible toggle and draining options)

@philrenaud
Copy link
Contributor

Thanks for the info and great find. We've been able to find the cause and will fix this asap.

As a (temporary) workaround, in your chrome dev console, try doing the following:

localStorage.setItem('nomadTokenSecret', 'foo')

If you try to load your charts/logs/files after that, they should be fine.

Look for an upcoming fix for this soon, and my apologies for the bugs.

@philrenaud philrenaud pinned this issue Aug 27, 2022
@iluminae
Copy link
Author

@philrenaud workaround looks like it is working for me, thanks!

@heikkilamarko
Copy link

I can confirm that the workaround fixes this one too: #14331

@ednxzu
Copy link

ednxzu commented Aug 27, 2022

If I can add to this, it seems like the UI does not allow you to run job if ACL aren't setup anymore.
I went from 1.3.3 to 1.3.4 on a test cluster that doesnt have ACLs setup, and the UI will not work unless you setup ACLs (grayed out buttons with "you do not have the permissions to run job" message).

@iluminae
Copy link
Author

iluminae commented Aug 28, 2022

@philrenaud when using the workaround above, I still get an error when using the UI to change the job definition of a thing:

Plan Error
acl token lookup failed: index error: UUID must be 36 characters

so the workaround would have to be:

localStorage.setItem('nomadTokenSecret', 'thisisathirtysixcharacterlongstring!');

@philrenaud
Copy link
Contributor

Ah thank you! That'll teach me for using arbitrary metasyntactic variables.

@rismoney
Copy link

will we get a rather quick release when fixed, like a 1.3.5? A bunch of bug fixes in 1.3.4 are super helpful , but the ui bugs don't allow troubleshooting the alloc fs which kills a lot of inspectability ? TYVM!!!

@shantanugadgil
Copy link
Contributor

same question from me too ... would/could there be a 1.3.5 soonish? (UI fixes only)

I could deploy and report back if the various UI bugs are fixed/solved or still present.

@benvanstaveren
Copy link

benvanstaveren commented Aug 31, 2022

As requested, adding the following: in a multi-cluster setup, UI no longer allows me to select the cluster I want to operate on. This after an upgrade from 1.2.5 to 1.3.4, on a 4 cluster setup with ACL disabled.

The workaround posted earlier works for this, though :)

@lgfa29
Copy link
Contributor

lgfa29 commented Aug 31, 2022

Hi everyone 👋

Yes, we're planning to have a quick 1.3.5 release out today, so keep an eye out for the announcement, and apologies for the troubles in 1.3.4.

@shantanugadgil
Copy link
Contributor

Awaiting eagerly for 1.3.5 ...👍🏻🙏🏻

@lgfa29
Copy link
Contributor

lgfa29 commented Aug 31, 2022

1.3.5 is now available: https://releases.hashicorp.com/nomad/1.3.5/

I'm going to close this issue for now, but let us know if the problem persists.

Thank you for the patience and understanding everyone!

@lgfa29 lgfa29 closed this as completed Aug 31, 2022
@shantanugadgil
Copy link
Contributor

Deployed the servers with version 1.3.5 in the staging environment. The UI issues seem resolved. I shall try to deploy to production in a few hours and reconfirm here if it works as expected.

@Great-Stone Great-Stone unpinned this issue Sep 1, 2022
@shantanugadgil
Copy link
Contributor

I have deployed this to PROD as well and this works fine for now. The UI issues of the Exec button are no longer there.

@lgfa29 lgfa29 pinned this issue Sep 1, 2022
@lgfa29
Copy link
Contributor

lgfa29 commented Sep 1, 2022

I have deployed this to PROD as well and this works fine for now. The UI issues of the Exec button are no longer there.

Great! Thank you for the confirmation 🙂

@benvanstaveren
Copy link

I've just deployed to prod as well and it seems the UI issues are now resolved.

Just to throw in my 2 cents as well :)

@lgfa29 lgfa29 pinned this issue Sep 8, 2022
@lgfa29 lgfa29 unpinned this issue Sep 13, 2022
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

No branches or pull requests

8 participants