Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: fixed template validation panic in case of incorrect ChangeScript configuration #14374

Merged
merged 2 commits into from
Aug 29, 2022
Merged

bugfix: fixed template validation panic in case of incorrect ChangeScript configuration #14374

merged 2 commits into from
Aug 29, 2022

Conversation

pkazmierczak
Copy link
Contributor

Fixes #14367

@pkazmierczak pkazmierczak added theme/template backport/1.3.x backport to 1.3.x release line labels Aug 29, 2022
@pkazmierczak pkazmierczak self-assigned this Aug 29, 2022
tgross
tgross requested changes Aug 29, 2022
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @pkazmierczak!

nomad/structs/structs.go Outdated Show resolved Hide resolved
nomad/structs/structs.go Outdated Show resolved Hide resolved
tgross
tgross approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nomad/structs/structs.go Show resolved Hide resolved
@pkazmierczak pkazmierczak merged commit 80f96fd into main Aug 29, 2022
@pkazmierczak pkazmierczak deleted the b-structs-validation-panic branch August 29, 2022 15:11
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Aug 29, 2022
Merged
lgfa29 added a commit that referenced this pull request Aug 31, 2022
@lgfa29
changelog: add entry for #14374
4785ae0
DerekStrickland pushed a commit that referenced this pull request Aug 31, 2022
@lgfa29
changelog: add entry for #14374 (#14419)
2c2f6dc
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tgross tgross tgross approved these changes

@lgfa29 lgfa29 Awaiting requested review from lgfa29

Assignees

@pkazmierczak pkazmierczak

Labels
backport/1.3.x backport to 1.3.x release line theme/template
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nomad job plan errors with the below logs.
2 participants
@pkazmierczak @tgross