Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-hcl1 should imply -hcl2-strict=false #14384

Closed
michalgm opened this issue Aug 29, 2022 · 2 comments · Fixed by #14426
Closed

-hcl1 should imply -hcl2-strict=false #14384

michalgm opened this issue Aug 29, 2022 · 2 comments · Fixed by #14426
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/cli type/enhancement

Comments

@michalgm
Copy link

michalgm commented Aug 29, 2022

Nomad version

Nomad v1.3.4+ent

Operating system and Environment details

Debian 11

Issue

When running any command that takes the -hcl1 option, I get this error:

gmichalec@gmichalec:~/work/levantservice$ nomad plan -hcl1 -verbose /tmp/20220829121756/nomad.hcl.final
Invalid job options: cannot parse job file as HCLv1 and HCLv2 strict.

the workaround is to include -hcl2-strict=false, but this seems redundant and also will break our tooling if not all clients are updated to the nomad version that accepts the -hcl2-strict flag.

@lgfa29 lgfa29 added theme/cli stage/accepted Confirmed, and intend to work on. No timeline committment though. type/enhancement and removed type/bug labels Aug 31, 2022
@lgfa29
Copy link
Contributor

lgfa29 commented Aug 31, 2022

Hi @michalgm 👋

Thanks for the report and I think it makes sense, since this is a required combination of flags.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/cli type/enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants