Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: remove network from quota status output #14468

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Conversation

tgross
Copy link
Member

@tgross tgross commented Sep 6, 2022

As reported in #9920 (comment)

Network quotas were removed in Nomad 1.0.4. Remove the fields no longer in use
from the quota status output.


This PR won't run the test here because it's in the OSS repo, but I've verified the test passes locally in the ENT repo. Adding a fmt.Println to the test in the appropriate spot shows the following new output:

Name        = test
Description = <none>
Limits      = 1

Quota Limits
Region  CPU Usage  Memory Usage  Memory Max Usage  Variables Usage
global  0 / 100    0 / inf       0 / inf           0 / inf

Network quotas were removed in Nomad 1.0.4. Remove the fields no longer in use
from the `quota status` output.
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgross tgross merged commit bbd87ee into main Sep 6, 2022
@tgross tgross deleted the quota-status-no-network branch September 6, 2022 13:37
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants