Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Add client scheduling eligibility to heartbeat #14483

Merged
merged 4 commits into from
Sep 8, 2022

Conversation

angrycub
Copy link
Contributor

@angrycub angrycub commented Sep 7, 2022

Adds the client's scheduling eligibility to the NodeUpdateResponse so that the client is made aware of the server-side value. Takes a heartbeat to get the data to the client and one metrics window to shed the value with the former label, but it appears to be a net improvement over the current behavior.

Fixes #8965

@angrycub angrycub added type/bug theme/metrics stage/accepted Confirmed, and intend to work on. No timeline committment though. labels Sep 7, 2022
@angrycub angrycub self-assigned this Sep 7, 2022
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nomad/structs/structs.go Outdated Show resolved Hide resolved
@angrycub angrycub merged commit 61a6dbc into main Sep 8, 2022
@angrycub angrycub deleted the f-heartbeat-eligibility branch September 8, 2022 18:31
@angrycub angrycub changed the title Add client scheduling eligibility to heartbeat core: Add client scheduling eligibility to heartbeat Sep 8, 2022
@angrycub angrycub added backport/1.1.x backport to 1.1.x release line backport/1.2.x backport to 1.1.x release line backport/1.3.x backport to 1.3.x release line labels Sep 8, 2022
@github-actions
Copy link

github-actions bot commented Jan 7, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.1.x backport to 1.1.x release line backport/1.2.x backport to 1.1.x release line backport/1.3.x backport to 1.3.x release line stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/metrics type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metric label node_scheduling_availability does not update with changes.
3 participants