Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke FingerprintManager's Reload() func during agent's SIGHUP (Fixes #14614) #14615

Merged
merged 2 commits into from
Oct 6, 2022

Conversation

pruiz
Copy link
Contributor

@pruiz pruiz commented Sep 17, 2022

This PR addresses #14614, by adding the missing call to Fingerprint's Reload() method from within SIGHUP handling on agent's code.

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This has missed the merge window for Nomad 1.4.0, but I'll merge it once the GA goes out (shortly) and then it'll go out in the next regular release of Nomad.

@pruiz can you add a changelog file to this PR? It'll be at .changelog/14615.txt and have the format you can see in .changelog/14749.txt. For content, probably something like:

client: Fixed a bug where fingerprinters were not reloaded when the client configuration was reloaded with SIGHUP

(If you don't get to it before I'm ready to merge this, no worries. I see the PR has been open a little bit and it'll only take me a few minutes to add it.)

@tgross tgross added this to the 1.4.x milestone Oct 3, 2022
@pruiz
Copy link
Contributor Author

pruiz commented Oct 3, 2022

Added changelog file.

@tgross tgross moved this from Triaging to In Progress in Nomad - Community Issues Triage Oct 4, 2022
@tgross tgross merged commit 536260c into hashicorp:main Oct 6, 2022
Nomad - Community Issues Triage automation moved this from In Progress to Done Oct 6, 2022
@tgross
Copy link
Member

tgross commented Oct 6, 2022

Hi @pruiz! We had to push out a quick Nomad 1.4.1 patch, but this has now been merged and will go out in the next regular patch release.

@github-actions
Copy link

github-actions bot commented Feb 4, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants