-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specification of a custom job name/prefix for parameterized jobs #14631
Allow specification of a custom job name/prefix for parameterized jobs #14631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @geovannyAvelar! As I noted in #13594 (comment) I'm also going to tag @fumblehool here to see if they have additional thoughts on the implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @geovannyAvelar!
I've added a changelog entry for you and some docs. This missed the merge window for Nomad 1.4.0, which is going out very soon. Once that's been released, I'll merge this PR and it'll go out with the next regular release of Nomad (probably 1.4.1).
Hi @geovannyAvelar! We had to push out a quick Nomad 1.4.1 patch, but this has now been merged and will go out in the next regular patch release. |
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Now it's possible to use a custom prefix in the job ID of the parameterized jobs. It's just necessary to use a new flag called
id-prefix-template
onnomad job dispatch
command.This PR fixes #13594.