Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specification of a custom job name/prefix for parameterized jobs #14631

Merged
merged 3 commits into from
Oct 6, 2022
Merged

Allow specification of a custom job name/prefix for parameterized jobs #14631

merged 3 commits into from
Oct 6, 2022

Conversation

geovannyAvelar
Copy link
Contributor

@geovannyAvelar geovannyAvelar commented Sep 20, 2022

Now it's possible to use a custom prefix in the job ID of the parameterized jobs. It's just necessary to use a new flag called id-prefix-template on nomad job dispatch command.

This PR fixes #13594.

@geovannyAvelar geovannyAvelar changed the title Prefix on parameterized jobs dispatch ID Allow specification of a custom job name/prefix for parameterized jobs Sep 20, 2022
@tgross tgross self-requested a review September 21, 2022 12:56
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @geovannyAvelar! As I noted in #13594 (comment) I'm also going to tag @fumblehool here to see if they have additional thoughts on the implementation.

api/jobs.go Outdated Show resolved Hide resolved
nomad/structs/structs.go Outdated Show resolved Hide resolved
nomad/structs/structs.go Outdated Show resolved Hide resolved
api/jobs.go Outdated Show resolved Hide resolved
@tgross tgross added this to Needs Triage in Nomad - Community Issues Triage via automation Sep 21, 2022
@tgross tgross moved this from Needs Triage to In Progress in Nomad - Community Issues Triage Sep 21, 2022
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @geovannyAvelar!

I've added a changelog entry for you and some docs. This missed the merge window for Nomad 1.4.0, which is going out very soon. Once that's been released, I'll merge this PR and it'll go out with the next regular release of Nomad (probably 1.4.1).

@tgross tgross added this to the 1.4.x milestone Oct 4, 2022
@tgross tgross added theme/cli backport/1.4.x backport to 1.4.x release line theme/batch Issues related to batch jobs and scheduling labels Oct 4, 2022
@tgross
Copy link
Member

tgross commented Oct 6, 2022

Hi @geovannyAvelar! We had to push out a quick Nomad 1.4.1 patch, but this has now been merged and will go out in the next regular patch release.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.4.x backport to 1.4.x release line theme/batch Issues related to batch jobs and scheduling theme/cli
Projects
Development

Successfully merging this pull request may close these issues.

Allow specification of a custom job name/prefix for parameterized jobs
2 participants