Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jobspec: allow artifact headers in HCLv1 #14637

Merged
merged 3 commits into from
Sep 27, 2022

Conversation

jimrazmus
Copy link
Contributor

@jimrazmus jimrazmus commented Sep 21, 2022

This test fixture comes straight from the documentation and uncovers a failure in parsing the 'headers' key.

Closes #14657

@hashicorp-cla
Copy link

hashicorp-cla commented Sep 21, 2022

CLA assistant check
All committers have signed the CLA.

@jimrazmus
Copy link
Contributor Author

See also #14657

@lgfa29 lgfa29 changed the title test: add fixture for artifact with headers jobspec: allow artifact headers in HCLv1 Sep 22, 2022
@lgfa29 lgfa29 added backport/1.1.x backport to 1.1.x release line backport/1.2.x backport to 1.1.x release line backport/1.3.x backport to 1.3.x release line labels Sep 22, 2022
@lgfa29 lgfa29 added this to the 1.4.0 milestone Sep 22, 2022
Copy link
Contributor

@DerekStrickland DerekStrickland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.1.x backport to 1.1.x release line backport/1.2.x backport to 1.1.x release line backport/1.3.x backport to 1.3.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Golang API reports Artifact Headers are an invalid key
5 participants