scheduler: Fix bug where the would treat multiregion jobs as paused for job types that don't use deployments #14659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or job types that don't use deployments
DerekStrickland
added
backport/1.2.x
Comment on lines
+5752
to
+5757
| switch j.Type { | ||
| case JobTypeService: | ||
| return true | ||
| default: | ||
| return false | ||
| } |
There was a problem hiding this comment.
Could this not be simplified?
Suggested change
| switch j.Type { | |
| case JobTypeService: | |
| return true | |
| default: | |
| return false | |
| } | |
| return j.Type == JobTypeService |
There was a problem hiding this comment.
It could, but I intentionally did this since a goal is to support Deployments for more job types in the future. Maybe this is premature? I was hoping the team would discuss so thanks for taking the bait!
Co-authored-by: Tim Gross <tgross@hashicorp.com>
This was referenced Sep 22, 2022
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the
allocReconcilerwhere multiregion job types that don't support deployments would be flagged as paused.structs.Job- Added aUsesDeploymentsfunction that can be expanded as more job types support deploymentsscheduler.allocReconciler- Added check tocomputeDeploymentPausedto guard against settingdeploymentPaused = trueif the job type doesn't use deployments.