Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Job spec upload #14747

Merged
merged 8 commits into from
Nov 2, 2022
Merged

Job spec upload #14747

merged 8 commits into from
Nov 2, 2022

Conversation

philrenaud
Copy link
Contributor

@philrenaud philrenaud commented Sep 29, 2022 •
edited
Loading

Contributes to #14744

Adds the ability to upload a job spec file

image

@philrenaud philrenaud self-assigned this Sep 29, 2022
@philrenaud philrenaud linked an issue Sep 29, 2022 that may be closed by this pull request
[ui] Give users an option to run a job from URL, or by dragging/uploading a job spec #14744
Closed
@github-actions
Copy link

github-actions bot commented Sep 29, 2022 •
edited
Loading

Ember Asset Size action

As of 0cb67a7

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +5.32 kB +961 B
nomad-ui.css +381 B +29 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Sep 29, 2022 •
edited
Loading

Ember Test Audit comparison

main 0cb67a7 change
passes 1426 1425 -1
failures 0 0 0
flaky 0 0 0
duration 10m 01s 921ms 10m 44s 082ms +42s 161ms

@juliezzhou
Copy link

lgtm!

@philrenaud philrenaud added the backport/1.4.x backport to 1.4.x release line label Oct 18, 2022
@philrenaud philrenaud merged commit 8a95f12 into main Nov 2, 2022
@philrenaud philrenaud deleted the 14744-ui-job-spec-upload branch November 2, 2022 14:34
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Nov 2, 2022
Merged
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ChaiWithJai ChaiWithJai ChaiWithJai approved these changes

@angrycub angrycub Awaiting requested review from angrycub

@mikenomitch mikenomitch Awaiting requested review from mikenomitch

@juliezzhou juliezzhou Awaiting requested review from juliezzhou

Assignees

@philrenaud philrenaud

Labels
backport/1.4.x backport to 1.4.x release line
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ui] Give users an option to run a job from URL, or by dragging/uploading a job spec
3 participants
@philrenaud @juliezzhou @ChaiWithJai