Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update consul-template for Nomad Variables #14762

Closed
tgross opened this issue Sep 30, 2022 · 2 comments · Fixed by #15045
Closed

deps: update consul-template for Nomad Variables #14762

tgross opened this issue Sep 30, 2022 · 2 comments · Fixed by #15045
Assignees
@angrycub @tgross
Labels
theme/dependencies Pull requests that update a dependency file theme/variables Variables feature
Milestone
1.4.2

Comments

@tgross
Copy link
Member

tgross commented Sep 30, 2022

A reminder for post-Nomad 1.4.0:

We've got a PR open hashicorp/consul-template#1632 that adds support for Nomad Variables. Because the timelines for releasing consul-template, releasing Nomad 1.4.0-beta.1, and release Nomad 1.4.0 GA are intertwined, we decided there that Nomad would release with go.mod pointing to the commit at the HEAD of that PR. Once that's been merged and consul-template has done a release, we'll update Nomad's go.mod with the "proper" release tag.
@tgross tgross added theme/dependencies Pull requests that update a dependency file theme/variables Variables feature labels Sep 30, 2022
@tgross tgross added this to the 1.4.x milestone Sep 30, 2022
@tgross tgross mentioned this issue Sep 30, 2022
Merged
@tgross
Copy link
Member Author

tgross commented Oct 4, 2022

Consul-Template 0.29.5 just shipped with a different bug fix that impacts Nomad so we'll want to pick this up for Nomad 1.4.1.

@tgross tgross modified the milestones: 1.4.x, 1.4.2 Oct 21, 2022
@tgross tgross linked a pull request Oct 26, 2022 that will close this issue
[deps] Update consul-template dependency #15045
Merged
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@angrycub angrycub

@tgross tgross

Labels
theme/dependencies Pull requests that update a dependency file theme/variables Variables feature
Projects
None yet
Milestone
1.4.2
Development

Successfully merging a pull request may close this issue.

[deps] Update consul-template dependency hashicorp/nomad
2 participants
@angrycub @tgross