Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acl: gate ACL role write and delete RPC usage on v1.4.0 or greater. #14908

Merged
merged 2 commits into from
Oct 18, 2022

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Oct 17, 2022

This ensures all federated servers are running v1.4.0 or greater before the use of ACL roles is allowed.

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if my comment about writing tokens with roles is off-base, otherwise we might want to look at that too.

nomad/acl_endpoint.go Show resolved Hide resolved
@tgross tgross added this to the 1.4.2 milestone Oct 17, 2022
jrasell added a commit that referenced this pull request Oct 18, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.4.x backport to 1.4.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants