make version checks specific to region (1.2.x) #14910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
added
type/bug
theme/auth
backport/1.2.x
tgross
force-pushed
the
b-region-filter-server-version-check-1.1
branch
from
a6feda2
to
cd1c80c
Compare
This was referenced Oct 17, 2022
shoenig
approved these changes
Oct 17, 2022
* One-time tokens are not replicated between regions, so we don't want to enforce that the version check across all of serf, just members in the same region. * Cleans up a bunch of legacy checks. This changeset is specific to 1.2.x and the changes for other versions of Nomad will be manually backported in separate PRs
tgross
force-pushed
the
b-region-filter-server-version-check-1.1
branch
from
cd1c80c
to
77e9a4e
Compare
tgross
removed
backport/1.2.x
tgross
changed the title
shoenig
approved these changes
Oct 17, 2022
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that the version check across all of serf, just members in the same region.
This changeset is specific to 1.2.x and the changes for other versions of
Nomad will be manually backported in separate PRs.
(And yes the 1.1 in the branch name is wrong 😁 )