Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make version checks specific to region (1.3.x) #14911

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

tgross
Copy link
Member

@tgross tgross commented Oct 17, 2022

  • One-time tokens are not replicated between regions, so we don't want to enforce
    that the version check across all of serf, just members in the same region.
  • Scheduler: Disconnected clients handling is specific to a single region, so we
    don't want to enforce that the version check across all of serf, just members in
    the same region.
  • Cleans up a bunch of legacy checks.

This changeset is specific to 1.3.x and the changes for other versions of
Nomad will be manually backported in separate PRs

* One-time tokens are not replicated between regions, so we don't want to enforce
  that the version check across all of serf, just members in the same region.
* Scheduler: Disconnected clients handling is specific to a single region, so we
  don't want to enforce that the version check across all of serf, just members in
  the same region.
* Cleans up a bunch of legacy checks.

This changeset is specific to 1.3.x and the changes for other versions of
Nomad will be manually backported in separate PRs
@tgross tgross force-pushed the b-region-filter-server-version-check-1.3 branch from d94c14d to be58566 Compare October 17, 2022 19:50
@tgross tgross changed the title scheduler: make version checks specific to region make version checks specific to region (1.3.x) Oct 17, 2022
@tgross tgross changed the base branch from main to release/1.3.x October 17, 2022 19:50
@tgross tgross removed backport/1.3.x backport to 1.3.x release line backport/1.4.x backport to 1.4.x release line labels Oct 17, 2022
@tgross tgross marked this pull request as ready for review October 17, 2022 19:56
@tgross tgross requested a review from shoenig October 17, 2022 20:07
@tgross tgross merged commit a130c7c into release/1.3.x Oct 17, 2022
@tgross tgross deleted the b-region-filter-server-version-check-1.3 branch October 17, 2022 20:23
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant