Adds searching and filtering for nodes on topology view #14913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaiWithJai
approved these changes
Oct 17, 2022
philrenaud
commented
Oct 17, 2022
| @alias('userSettings.showTopoVizPollingNotice') showPollingNotice; | ||
|
|
||
| @tracked filteredNodes = null; | ||
| @tracked pre09Nodes = null; |
There was a problem hiding this comment.
Because we want to be able to filter nodes now, I've renamed what was filteredNodes to pre09Nodes. This modifies the code added from #9733 but I think in a healthy way. cc @DingoEatingFuzz
Ember Asset Size actionAs of a6331cf Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
|
|
Ember Test Audit comparison
|
mikenomitch
reviewed
Oct 17, 2022
|
Many many many many thanks 🎉 ! It makes topology view finally useful for our Nomad usage 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a toolbar for searching and filtering clients within the Topology view, and really ties the room together.
Resolves #10002