Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass command and trust_prefix to the validation of rkt task configuration #1493

Merged
merged 3 commits into from
Aug 5, 2016
Merged

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Aug 1, 2016

No description provided.

@dadgar
Copy link
Contributor

dadgar commented Aug 2, 2016

Those values are not passable in the driver config?

@nak3
Copy link
Contributor Author

nak3 commented Aug 2, 2016

Thank you. I added them to the driver config.

@dadgar
Copy link
Contributor

dadgar commented Aug 3, 2016

We should add some tests for the new flags before merging this

@nak3
Copy link
Contributor Author

nak3 commented Aug 4, 2016

Thank you. I added tests. TestRktTaskValidate might not be necessary, since other drivers don't do this.

@dadgar
Copy link
Contributor

dadgar commented Aug 4, 2016

Looks good! Last thing I forgot is please add the new fields to the rkt docs. https://github.com/hashicorp/nomad/blob/master/website/source/docs/drivers/rkt.html.md

@nak3
Copy link
Contributor Author

nak3 commented Aug 5, 2016

Thank you. The docs already has the field command and trust_prefix. Should I still need to add something?

@dadgar
Copy link
Contributor

dadgar commented Aug 5, 2016

Oh you are right! Sorry

@dadgar dadgar merged commit 3c33c54 into hashicorp:master Aug 5, 2016
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants