Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update go-memdb for goroutine leak fix #14983

Merged
merged 2 commits into from
Oct 20, 2022
Merged

deps: update go-memdb for goroutine leak fix #14983

merged 2 commits into from
Oct 20, 2022

Conversation

shoenig
Copy link
Member

@shoenig shoenig commented Oct 20, 2022 •
edited
Loading

May as well slip this in for the bugfix releases
hashicorp/go-memdb#128

@shoenig shoenig added this to the 1.4.2 milestone Oct 20, 2022
@shoenig shoenig added backport/1.2.x backport to 1.1.x release line backport/1.3.x backport to 1.3.x release line backport/1.4.x backport to 1.4.x release line labels Oct 20, 2022
jrasell
jrasell approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Might want a changelog entry so it's called out and easy to find if someone experiences behaviour that fits.

@shoenig shoenig merged commit e81dae1 into main Oct 20, 2022
@shoenig shoenig deleted the deps-update-go-memdb branch October 20, 2022 15:34
This was referenced Oct 20, 2022
Merged
Merged
Merged
shoenig added a commit that referenced this pull request Oct 20, 2022
@shoenig
deps: update go-memdb for goroutine leak fix (#14983)
30c5dd0 
manual cherry-pick

* deps: update go-memdb for goroutine leak fix

* cl: update for goroutine leak go-memdb
shoenig added a commit that referenced this pull request Oct 20, 2022
@shoenig
deps: update go-memdb for goroutine leak fix (#14983)
09d6ab6 
manual cherry-pick

* deps: update go-memdb for goroutine leak fix

* cl: update for goroutine leak go-memdb
shoenig added a commit that referenced this pull request Oct 20, 2022
@hc-github-team-nomad-core @shoenig
deps: update go-memdb for goroutine leak fix (#14983) (#14985)
7996f64 
manual cherry-pick

* deps: update go-memdb for goroutine leak fix

* cl: update for goroutine leak go-memdb

Co-authored-by: Seth Hoenig <shoenig@duck.com>
shoenig added a commit that referenced this pull request Oct 21, 2022
@hc-github-team-nomad-core @shoenig
deps: update go-memdb for goroutine leak fix (#14983) (#14984)
496e7c0 
manual cherry-pick

* deps: update go-memdb for goroutine leak fix

* cl: update for goroutine leak go-memdb

Co-authored-by: Seth Hoenig <shoenig@duck.com>
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrasell jrasell jrasell approved these changes

Assignees
No one assigned
Labels
backport/1.2.x backport to 1.1.x release line backport/1.3.x backport to 1.3.x release line backport/1.4.x backport to 1.4.x release line
Projects
None yet
Milestone
1.4.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shoenig @jrasell