Allow operators to opt into publishing node and alloc metrics #1501
Conversation
| c.emitStats(ru) | ||
|
|
||
| // Publish Node metrics if operator has opted in | ||
| if c.config.PublishNodeMetrics { |
There was a problem hiding this comment.
It looks like you check the config settings inside the function. Are you sure you need the guard up here?
There was a problem hiding this comment.
@slackpad We do that in the emitMetrics method of task runners, this is for the emitMetrics method of the Client which sends host related metrics.
|
cc/ @dadgar |
| @@ -1,5 +1,9 @@ | |||
| ## 0.4.1 (UNRELEASED) | |||
|
|
|||
| __BACKWARDS INCOMPATIBILITIES:__ | |||
There was a problem hiding this comment.
I would make it default as true and let people who want to disable it disable it.
There was a problem hiding this comment.
We are keeping the default false since the volume of metrics Nomad emits is quite large.
|
We will open a follow up PR which will allow a tunable for operators to opt-in for nomad-internals related metrics. |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes #1499