client: ensure minimal cgroup controllers enabled #15027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes a bug where Nomad could not operate properly on operating systems that set the root cgroup.subtree_control to a set of controllers that do not include the minimal set of controllers needed by Nomad. Nomad needs these controllers enabled to operate: - cpuset - cpu - io - memory - pids Now, Nomad will ensure these controllers are enabled during Client initialization, adding them to cgroup.subtree_control as necessary. This should be particularly helpful on the RHEL/CentOS/Fedora family of system. Ubuntu systems should be unaffected as they enable all controllers by default. Fixes: #14494
shoenig
force-pushed
the
b-centos-cg2-fix
branch
from
709460e
to
fb67296
Compare
shoenig
added
backport/1.3.x
shoenig
commented
Oct 24, 2022
tgross
approved these changes
Oct 24, 2022
| parentAbs := filepath.Join(CgroupRoot, parent) | ||
| if err := os.MkdirAll(parentAbs, 0o755); err != nil { | ||
| logger.Warn("failed to ensure nomad parent cgroup exists; disable cpuset management", "error", err) | ||
| logger.Error("failed to ensure nomad parent cgroup exists; disable cpuset management", "error", err) |
There was a problem hiding this comment.
Can we change these log entries to say "disabling cpuset management"? "disable" sounds like we're telling the cluster administrator to do it.
|
spot check on CentOS 9 AMI |
This was referenced Oct 24, 2022
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where Nomad could not operate properly on operating
systems that set the root
cgroup.subtree_controlto a set of controllers thatdo not include the minimal set of controllers needed by Nomad.
Nomad needs these controllers enabled to operate:
Now, Nomad will ensure these controllers are enabled during Client initialization,
adding them to
cgroup.subtree_controlas necessary. This should be particularlyhelpful on the RHEL/CentOS/Fedora family of system. Ubuntu systems should be
unaffected as they enable all controllers by default.
Fixes: #14494
Backports to 1.4.x and 1.3.x (1.2.x predates cgroups v2 support)