Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable root keyring garbage collection #15088

Closed
tgross opened this issue Oct 31, 2022 · 3 comments
Closed

re-enable root keyring garbage collection #15088

tgross opened this issue Oct 31, 2022 · 3 comments

Comments

@tgross
Copy link
Member

tgross commented Oct 31, 2022

In #15034 we removed root keyring GC so that we wouldn't leave orphaned Workload Identities that could no longer be verified. Currently Workload Identities are expired on the basis of allocation lifespan -- once an allocation is terminal, the WI is no longer valid.

But the plan is to allow third-parties to validate Workload Identities by checking the server's public key. At this point, we'll need WIs to have expiration timers so that the third-party can know whether a WI claim is still valid without having to hit the Nomad API (once the third-party has the public key, of course). At that point, we'll need to have a mechanism to rotate already-signed WIs the same way we do for things like Vault bearer tokens. That should let us safely GC root keys because we'll definitively know they can't have signed a WI older than t minutes/hours/days (whatever we set the expiration to).

(cc @angrycub @mikenomitch as a heads up)

@tgross
Copy link
Member Author

tgross commented Oct 31, 2022

Draft PR is up #15092

@tgross
Copy link
Member Author

tgross commented Nov 1, 2022

Closed by #15092

@tgross tgross closed this as completed Nov 1, 2022
@tgross tgross added this to the 1.4.3 milestone Nov 1, 2022
@github-actions
Copy link

github-actions bot commented Mar 2, 2023

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant