Remove docker volumes while removing container #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove docker volumes while exiting container
Remove container volumes
|
@diptanu - Any idea why all the builds are failing for PRs? - https://travis-ci.org/hashicorp/nomad/pull_requests |
|
@vrenjith We recently changed how we run the tests which has sped it up a bit but due to that some flakiness has come and we haven't had time to run through the tests yet as they only break on travis, the fix cycle is quite long. |
|
Nice thanks! |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the docker volumes are left on the disk and the host machines disk is getting filled up with the unused docker volumes from the removed containers.
This attempts to fix it.