-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: wait
flag for use with deployment status -monitor
#15262
cli: wait
flag for use with deployment status -monitor
#15262
Conversation
deployment status
with -monitor
flagdeployment status -monitor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @jdockerty!
To get this into mergeable state:
- Address the comments.
- Run
make cl
to add a changelog entry for the flag. - Add the docs for the flag to the
deployment status
docs in status.mdx - Mark it ready for review!
I think at some point someone is going to want to come along and add this feature to job run
too, but looking at the code for that the monitoring is a bit more complex because we monitor an eval and then switch to monitoring the deployment. What you've got here does the job asked and is worth shipping on its own. 😀
Co-authored-by: Tim Gross <tgross@hashicorp.com>
deployment status -monitor
wait
flag for use with deployment status -monitor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @jdockerty!
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Addresses comments laid out in #11068