Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: wait flag for use with deployment status -monitor #15262

Merged
merged 8 commits into from
Nov 23, 2022

Conversation

jdockerty
Copy link
Contributor

@jdockerty jdockerty commented Nov 15, 2022

Addresses comments laid out in #11068

@hashicorp-cla
Copy link

hashicorp-cla commented Nov 15, 2022

CLA assistant check
All committers have signed the CLA.

@jdockerty jdockerty changed the title cli: wait-time for deployment status with -monitor flag cli: wait-time flag for use with deployment status -monitor Nov 15, 2022
@tgross tgross added this to Needs Triage in Nomad - Community Issues Triage via automation Nov 16, 2022
@tgross tgross self-requested a review November 22, 2022 21:36
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @jdockerty!

To get this into mergeable state:

  • Address the comments.
  • Run make cl to add a changelog entry for the flag.
  • Add the docs for the flag to the deployment status docs in status.mdx
  • Mark it ready for review!

I think at some point someone is going to want to come along and add this feature to job run too, but looking at the code for that the monitoring is a bit more complex because we monitor an eval and then switch to monitoring the deployment. What you've got here does the job asked and is worth shipping on its own. 😀

command/deployment_status.go Outdated Show resolved Hide resolved
Co-authored-by: Tim Gross <tgross@hashicorp.com>
@jdockerty jdockerty marked this pull request as ready for review November 23, 2022 19:39
@jdockerty jdockerty changed the title cli: wait-time flag for use with deployment status -monitor cli: wait flag for use with deployment status -monitor Nov 23, 2022
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @jdockerty!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants