Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nomad should wait with cleaning docker images for faster startup times #1530

Closed
bsphere opened this issue Aug 6, 2016 · 6 comments
Closed

Comments

@bsphere
Copy link

bsphere commented Aug 6, 2016

Nomad version

0.4

Operating system and Environment details

CoreOS stable

Issue

Nomad removes docker images when tasks are stopped, but in case the task is restarted (e.g. consul-template update), startup times are wait too long because it pulls the images again.

Maybe Nomad can wait for some time before cleaning images to improve startup times.

@camerondavison
Copy link
Contributor

this could also help with some of the docker race conditions that make cleaning up the images break docker due to docker bugs.

@diptanu
Copy link
Contributor

diptanu commented Aug 8, 2016

We will most likely solve this when we introduce artifact cache in the Nomad client. Docker containers or any other binaries would be downloaded and removed if available disk space is low and not in use.

@dbresson
Copy link

This enhancement will break the ability to update to a new revision of the same image tag.

@camerondavison
Copy link
Contributor

@dbresson see #639 I think you are mentioning that you would like to be able to restart a service and get a image even though the tag is the same, this is currently not supported, and you should not rely on this behavior. With #639 done then whatever flag is used to notify the client that it should always pull the latest image from the registry would make sure that this issue does not break the behavior you are talking about.

@dadgar
Copy link
Contributor

dadgar commented Aug 10, 2017

Hey this was fixed in 0.5.5 and made more robust in 0.5.6

@dadgar dadgar closed this as completed Aug 10, 2017
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants