Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] Show Consul Connect upstreams / on update info in sidebar #15324

Merged
merged 2 commits into from
Nov 19, 2022
Merged

[ui] Show Consul Connect upstreams / on update info in sidebar #15324

merged 2 commits into from
Nov 19, 2022

Conversation

philrenaud
Copy link
Contributor

image
image

@philrenaud philrenaud self-assigned this Nov 18, 2022
ChaiWithJai
ChaiWithJai approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@ChaiWithJai ChaiWithJai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philrenaud philrenaud force-pushed the f-ui/consul-connect-upstreams-in-service-sidebar branch from 439584c to cbac855 Compare November 18, 2022 22:04
@philrenaud philrenaud added the backport/1.4.x backport to 1.4.x release line label Nov 18, 2022
@github-actions
Copy link

github-actions bot commented Nov 18, 2022 •
edited
Loading

Ember Asset Size action

As of cbac855

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +1.62 kB +233 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Nov 18, 2022 •
edited
Loading

Ember Test Audit comparison

main cbac855 change
passes 1425 1425 0
failures 0 0 0
flaky 0 0 0
duration 9m 58s 941ms 12m 28s 301ms +2m 29s 360ms

@philrenaud philrenaud merged commit 4703f55 into main Nov 19, 2022
@philrenaud philrenaud deleted the f-ui/consul-connect-upstreams-in-service-sidebar branch November 19, 2022 03:49
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Nov 19, 2022
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ChaiWithJai ChaiWithJai ChaiWithJai approved these changes

@mikenomitch mikenomitch Awaiting requested review from mikenomitch

Assignees

@philrenaud philrenaud

Labels
backport/1.4.x backport to 1.4.x release line theme/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@philrenaud @ChaiWithJai