Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] Task sub row alignment changes #15363

Merged
merged 1 commit into from
Nov 22, 2022
Merged

[ui] Task sub row alignment changes #15363

merged 1 commit into from
Nov 22, 2022

Conversation

philrenaud
Copy link
Contributor

Resolves #15056

image

@philrenaud philrenaud added the backport/1.4.x backport to 1.4.x release line label Nov 22, 2022
@philrenaud philrenaud self-assigned this Nov 22, 2022
@philrenaud philrenaud linked an issue Nov 22, 2022 that may be closed by this pull request
New Task View on Job page alignment seems off #15056
Closed
@philrenaud philrenaud force-pushed the 15056-new-task-view-on-job-page-alignment-seems-off branch from 6b5d064 to 1c5036a Compare November 22, 2022 19:28
ChaiWithJai
ChaiWithJai approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@ChaiWithJai ChaiWithJai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, awesome job! LGTM.

@github-actions
Copy link

github-actions bot commented Nov 22, 2022 •
edited
Loading

Ember Asset Size action

As of 1c5036a

Files that got Bigger 🚨:

File raw gzip
nomad-ui.css +93 B +21 B

Files that stayed the same size 🤷‍:

File raw gzip
nomad-ui.js 0 B 0 B
vendor.js 0 B 0 B
vendor.css 0 B 0 B

@philrenaud philrenaud merged commit 1420433 into main Nov 22, 2022
@philrenaud philrenaud deleted the 15056-new-task-view-on-job-page-alignment-seems-off branch November 22, 2022 20:49
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Nov 22, 2022
Merged
@github-actions
Copy link

github-actions bot commented Nov 22, 2022 •
edited
Loading

Ember Test Audit comparison

main 1c5036a change
passes 1425 1425 0
failures 0 0 0
flaky 0 0 0
duration 10m 32s 319ms 13m 25s 711ms +2m 53s 392ms

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ChaiWithJai ChaiWithJai ChaiWithJai approved these changes

@juliezzhou juliezzhou Awaiting requested review from juliezzhou

Assignees

@philrenaud philrenaud

Labels
backport/1.4.x backport to 1.4.x release line
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Task View on Job page alignment seems off
2 participants
@philrenaud @ChaiWithJai