node-status outputs volumename instead of 0B utilization when non-physical volume is used #1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nak3
changed the title
| @@ -53,6 +53,8 @@ func (f *StorageFingerprint) Fingerprint(cfg *config.Config, node *structs.Node) | |||
| node.Attributes["unique.storage.bytestotal"] = strconv.FormatUint(total, 10) | |||
| node.Attributes["unique.storage.bytesfree"] = strconv.FormatUint(free, 10) | |||
|
|
|||
| f.logger.Printf("[DEBUG] fingerprint.storage: volume: %s, total: %d Byte, free: %d Byte", volume, total, free) | |||
There was a problem hiding this comment.
Since the node attributes can be queried from the cli and api, we don't need a debug message here.
|
Nice this is cool! |
|
Thank you! I updated by deleting the debug message. |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
nomad node-status outputs
Disk 0 B/0 B.This is one of the issues reported in #1374.
Root cause
nomad client collects disk data from physical partitions only. So,
tmpfsis not collected. Ref -disk.Partitions(false) and shirou/gopsutil's code
Change
This PR changes nomad to output only volume name instead of
0 Bwhen non-physical volume is used.(e.g)