Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Show task events in the sidebar #15733

Merged
merged 3 commits into from
Jan 10, 2023

Conversation

philrenaud
Copy link
Contributor

Shows Task Events in the Nomad UI sidebar. Accessible via Job or Task Group pages.
Resolves #15730

image

@philrenaud philrenaud added the backport/1.4.x backport to 1.4.x release line label Jan 9, 2023
@philrenaud philrenaud self-assigned this Jan 9, 2023
@philrenaud philrenaud linked an issue Jan 9, 2023 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Jan 9, 2023

Ember Asset Size action

As of 5840333

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +2.04 kB +335 B
nomad-ui.css +216 B +28 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Jan 9, 2023

Ember Test Audit comparison

main 5840333 change
passes 1452 1452 0
failures 0 0 0
flaky 0 0 0
duration 10m 24s 982ms 11m 07s 720ms +42s 738ms

@philrenaud philrenaud merged commit 83d7387 into main Jan 10, 2023
@philrenaud philrenaud deleted the 15730-ui-show-task-events-in-the-sidebar branch January 10, 2023 22:02
philrenaud added a commit that referenced this pull request Jan 16, 2023
* Add task events to task logs sidebar

* Max-heighting inner table when present for nice looking borders
philrenaud added a commit that referenced this pull request Jan 16, 2023
…15751)

* no-op commit due to failed cherry-picking

* [ui] Show task events in the sidebar (#15733)

* Add task events to task logs sidebar

* Max-heighting inner table when present for nice looking borders

Co-authored-by: temp <temp@hashicorp.com>
Co-authored-by: Phil Renaud <phil.renaud@hashicorp.com>
philrenaud added a commit that referenced this pull request Jan 23, 2023
* Add task events to task logs sidebar

* Max-heighting inner table when present for nice looking borders
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.4.x backport to 1.4.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ui] Show Task Events in the Sidebar
2 participants