Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Task Logs sidebar expansion button #15735

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

philrenaud
Copy link
Contributor

Resolves #15731

sidebar.resizer.mov

@github-actions
Copy link

github-actions bot commented Jan 9, 2023

Ember Asset Size action

As of a7f7266

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +1.21 kB +233 B
nomad-ui.css +208 B +53 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Jan 9, 2023

Ember Test Audit comparison

main a7f7266 change
passes 1452 1452 0
failures 0 0 0
flaky 0 0 0
duration 11m 30s 213ms 10m 26s 551ms -1m 03s 662ms

@ChaiWithJai
Copy link
Contributor

@philrenaud LGTM but test-ui appears to be failing....

@philrenaud philrenaud force-pushed the 15731-ui-allow-expanding-a-sidebar-to-full-width branch from f66be49 to a7f7266 Compare January 10, 2023 20:21
@philrenaud philrenaud added the backport/1.4.x backport to 1.4.x release line label Jan 10, 2023
@philrenaud philrenaud merged commit 17531ca into main Jan 10, 2023
@philrenaud philrenaud deleted the 15731-ui-allow-expanding-a-sidebar-to-full-width branch January 10, 2023 21:35
philrenaud added a commit that referenced this pull request Jan 23, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.4.x backport to 1.4.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ui] Allow expanding a sidebar to full width
2 participants