Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] Fixes logger height issue when sidebar has events #15759

Merged
merged 2 commits into from
Jan 13, 2023
Merged

[ui] Fixes logger height issue when sidebar has events #15759

merged 2 commits into from
Jan 13, 2023

Conversation

philrenaud
Copy link
Contributor

No description provided.

@philrenaud philrenaud self-assigned this Jan 11, 2023
@philrenaud philrenaud force-pushed the b-ui/task-sidebar-logger-height-fix branch from ac6b57c to 8edc713 Compare January 11, 2023 18:00
@github-actions
Copy link

github-actions bot commented Jan 11, 2023 •
edited
Loading

Ember Asset Size action

As of 66f908a

Files that got Bigger 🚨:

File raw gzip
nomad-ui.css +313 B +63 B

Files that got Smaller 🎉:

File raw gzip
nomad-ui.js -31 B -4 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Jan 11, 2023 •
edited
Loading

Ember Test Audit comparison

main 66f908a change
passes 1452 1452 0
failures 0 0 0
flaky 0 0 0
duration 10m 25s 903ms 12m 02s 883ms +1m 36s 980ms

@philrenaud philrenaud force-pushed the b-ui/task-sidebar-logger-height-fix branch from b22f35a to 66f908a Compare January 13, 2023 16:27
@philrenaud philrenaud merged commit 055d32a into main Jan 13, 2023
@philrenaud philrenaud deleted the b-ui/task-sidebar-logger-height-fix branch January 13, 2023 17:16
@philrenaud philrenaud added the backport/1.4.x backport to 1.4.x release line label Jan 16, 2023
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Jan 16, 2023
Merged
philrenaud added a commit that referenced this pull request Jan 23, 2023
@philrenaud
[ui] Fixes logger height issue when sidebar has events (#15759)
a63156b 
* Fixes logger height issue when sidebar has events

* Much simpler grid method for height calc
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ChaiWithJai ChaiWithJai ChaiWithJai approved these changes

@mikenomitch mikenomitch Awaiting requested review from mikenomitch

Assignees

@philrenaud philrenaud

Labels
backport/1.4.x backport to 1.4.x release line
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@philrenaud @ChaiWithJai