Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in nomad fmt -check does not return error code #15797

Merged
merged 2 commits into from
Jan 17, 2023

Conversation

dttung2905
Copy link
Contributor

Hi team,

This PR is to resolve issue #15740. Could you help to review when you have time ?

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Copy link

@WebLeash WebLeash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good from what I understand of golang.

@tgross tgross linked an issue Jan 17, 2023 that may be closed by this pull request
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @dttung2905! Thanks for picking this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.4.x backport to 1.4.x release line type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nomad fmt -check flag doesn't return error code
3 participants