-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qemu driver: Task customization using config arguments #1588
Comments
I have patched qemu.go, qemu_test.go, and updated the documentation locally. However, I am unable to create a pull request due to permission issues. Here is a diff for your cursory review -
|
Do you think I should fork and do the update to raise a pull request ? |
@ramukima Yes, please fork and open a PR. |
I think we should keep the current args as is for backwards compatibility and if |
@dadgar Not sure. The issue I have is "My VM with embedded default image and self configurability does not boot with config properly if I use the current qemu driver". I needed to remove "-nodefaults" option in order to make it work for my VM. The original issue I have will not be resolved if I keep the existing defaulted options. I may have to introduce a "compatibility" flag in that case to fallback. Do you agree ? |
Hmm okay good point. I would forgo the compatibility flag and ignore my previous comment |
Here is the pull request : #1596 |
Closing as #1596 was merged |
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Nomad version
Output from
nomad version
Nomad v0.4.1-dev ('08628fea9058aeff80f9320cd350453a048f6153+CHANGES')
Operating system and Environment details
Linux 4.4.0-34-generic #53-Ubuntu x86_64
Issue
VM qcow2 image with embedded boot configuration is successfully deployed but does not boot with default configuration due to the options specified to the qemu driver by default.
Reference Discussion Thread : https://groups.google.com/forum/#!topic/nomad-tool/F1ZbRtrB9zc
The idea is to allow task configuration argument as a passthrough to qemu executable instead of hard-coding that in the driver.
The text was updated successfully, but these errors were encountered: