Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: fix alloc memory stats to match CLI output #15909

Merged
merged 2 commits into from
Jan 26, 2023
Merged

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Jan 26, 2023

Match memory usage logic with the CLI.

Closes #15830

@lgfa29 lgfa29 added backport/1.3.x backport to 1.3.x release line backport/1.4.x backport to 1.4.x release line labels Jan 26, 2023
@github-actions
Copy link

github-actions bot commented Jan 26, 2023

Ember Asset Size action

As of 02e5390

Files that got Smaller 🎉:

File raw gzip
nomad-ui.js -55 B +5 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

Copy link
Contributor

@ChaiWithJai ChaiWithJai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Jan 26, 2023

Ember Test Audit comparison

main 02e5390 change
passes 1452 1452 0
failures 0 0 0
flaky 0 0 0
duration 10m 23s 382ms 10m 50s 934ms +27s 552ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.3.x backport to 1.3.x release line backport/1.4.x backport to 1.4.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exec driver is showing cache+RSS in memory usage UI view
3 participants