Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to revert job to older version #15964

Closed
vincenthuynh opened this issue Jan 30, 2023 · 1 comment · Fixed by #15996
Closed

Unable to revert job to older version #15964

vincenthuynh opened this issue Jan 30, 2023 · 1 comment · Fixed by #15996
Assignees
@shoenig
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/consul type/bug
Milestone
1.4.x

Comments

@vincenthuynh
Copy link

Nomad version

Nomad v1.3.8 (353d07bde4532a49446fbb76cfe19cf74af59d9d)
Consul v1.12.8 Revision 12dd8aa9

Operating system and Environment details

Issue

Reopening #12822

Reproduction steps

nomad job revert -consul-token "$CONSUL_HTTP_TOKEN" -verbose myjob 14

Expected Result

JSON response as seen in: https://www.nomadproject.io/api-docs/jobs#revert-to-older-job-version

Actual Result

Error retrieving job versions: Unexpected response code: 500 (rpc error: job-submitter consul token denied: missing consul token)
@shoenig shoenig self-assigned this Jan 31, 2023
@shoenig
Copy link
Member

shoenig commented Jan 31, 2023

Thanks for the report @vincenthuynh, indeed I can reproduce with a simple Consul + ACLs setup and Nomad on main

➜ nomad version 
Nomad v1.4.4-dev (7f3bdd4359c6232f0ccb50ce0d799adc083c8b32)

➜ nomad job run -consul-token=d755c17e-e2f6-b4c5-03ac-495bd749ca10 bug.nomad
...
  ✓ Deployment "c058f66f" successful

➜ nomad job revert -consul-token=d755c17e-e2f6-b4c5-03ac-495bd749ca10 bug 0
Error retrieving job versions: Unexpected response code: 500 (job-submitter consul token denied: missing consul token)

@shoenig shoenig added this to the 1.4.x milestone Jan 31, 2023
@shoenig shoenig added the stage/accepted Confirmed, and intend to work on. No timeline committment though. label Jan 31, 2023
@shoenig shoenig mentioned this issue Jan 31, 2023
Merged
This was referenced Feb 1, 2023
Merged
Merged
Merged
@vincenthuynh vincenthuynh mentioned this issue Apr 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shoenig shoenig

Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/consul type/bug
Projects
None yet
Milestone
1.4.x
Development

Successfully merging a pull request may close this issue.

consul: restore consul token when reverting a job hashicorp/nomad
2 participants
@shoenig @vincenthuynh