Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nomad does not mark deployment as successful with dynamic service names #16382

Closed
Blefish opened this issue Mar 8, 2023 · 1 comment · Fixed by #16402
Closed

Nomad does not mark deployment as successful with dynamic service names #16382

Blefish opened this issue Mar 8, 2023 · 1 comment · Fixed by #16402
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/service-discovery type/bug

Comments

@Blefish
Copy link

Blefish commented Mar 8, 2023

Nomad version

Output from nomad version
Nomad v1.4.5, v1.5.0

Operating system and Environment details

Linux Mint 21.1

Issue

Services with dynamic names never report healthy deployment status, although services are healthy in Consul view. Seems to be occuring after #15822 , could it be that dynamic service name is not being evaluated before validating the service checks?

Reproduction steps

Expected Result

Service healthiness result from Consul is forwarded to Nomad and deployment is successful.

Actual Result

Service healthiness is not received by Nomad and deployment is marked as failed after a while.

Job file (if appropriate)

A service which uses custom name that is dynamically evaluated (NOMAD_GROUP_NAME, NOMAD_JOB_NAME or similar)

service {
  name = "${NOMAD_JOB_NAME}"
  port = "grpc"
  check {
    type = "grpc"
    interval = "10s"
    timeout = "5s"
    check_restart {
      limit = 3
      grace = "90s"
      ignore_warnings = false
    }
  }
}
@lgfa29
Copy link
Contributor

lgfa29 commented Mar 9, 2023

Thanks for the report @Blefish, your analysis was correct and there was a bug in #15822 where were not interpolating service values. I opened #16402 to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/service-discovery type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants