Disconnected allocations are not replaced during a canary deployment once resources are made available #16644
Labels
stage/accepted
Confirmed, and intend to work on. No timeline committment though.
theme/deployments
theme/edge
type/bug
Projects
Nomad version
Operating system and Environment details
MacOS
Issue
During a canary deployment that is pending promotion, if a client that has allocations with
max_client_disconnect
set is disconnected, and there are no available capacity to replace these allocations, the allocations are never replaced even when capacity is made available later on.Reproduction steps
Start 1 client and 1 server.
Run sample job with
max_client_disconnect
and anupdate
block.Update job (for example, change
image
toredis:6
). Once deployment is healthy and awaiting promotion, stop client. Allocations will eventually be marked asunknown
.Start a second client.
Expected Result
Allocations are placed in the new client.
Actual Result
No allocations are placed until the deployment is either promoted or failed.
Nomad Server logs (if appropriate)
The lack of log lines is the interesting point. The
createNodeEvals
needs to handle this case so anode-update
eval is created for the job being deployed.The text was updated successfully, but these errors were encountered: