-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[api] Add NetworkStatus to allocation response #17280
Conversation
Service discovery or mesh network systems consuming the Nomad event stream or API need to know the CNI assigned IP for the allocation. This data is returned by the underlying Nomad API but isn't mapped in the response struct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution @deverton-godaddy!
I pushed a commit to add a CHANGELOG entry and a quick test. I also reordered the struct fields so it matches the order in structs.go
, making it easier to finding missing fields (and I did notice some others missing here 😅)
Before we can merge this we will need you to sign the CLA. Would you be able to do that?
Thanks!
Thank you for taking the time to update this PR. I'm still working on getting CLA approval and will update as soon as I can. I'm hoping it should be in the next few days. |
@lgfa29 I've signed the CLA so this should be good to go. |
Ops, sorry I missed this @deverton-godaddy. Thanks for handling the CLA! |
Service discovery or mesh network systems consuming the Nomad event stream or API need to know the CNI assigned IP for the allocation. This data is returned by the underlying Nomad API but isn't mapped in the response struct in the Go client.