-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
progress_deadline set to 0 fails to validate #17335
Comments
Is there any chance of a release 1.3.16 that includes this fix...? 🤞 |
Thank you @lgfa29. Looks good after upgrading to 1.6.1. |
Hi @martinmcnulty 👋 Normally we wouldn't, as we usually only release n-2 versions and, with 1.6.0 released, the 1.3.x line is deprecated. But the team agrees that this is a particularly bad bug to have around so we'll release a 1.3.16 just with this bug fix. If all goes well it will be available by end of day today. |
@martinmcnulty v1.3.16 with the fix is now available |
@lgfa29 Many thanks! |
Nomad 1.5.6 with #16761 introduces a check for kill_timeout, but fails to consider progress_deadline set to 0.
It fails with
We don't have a kill timeout set, so 5s is the default.
As per documentation, progress_deadline set to 0 has special meaning:
We now have jobs that fails to validate/deploy. Is this a bug, or is progress_deadline set to 0 no longer supported?
The text was updated successfully, but these errors were encountered: