allow controlling the task stop signal

[jippi]

It would be nice to have a kill_singal config for tasks as not all programs react nicely to SIGINT :)

Example php-fpm handle signals like this

* SIGINT, SIGTERM: immediate termination 
* SIGQUIT: graceful stop 
* SIGUSR1: re-open log file 
* SIGUSR2: graceful reload of all workers + reload of fpm conf/binary 

where SIGINT will cause the process to die right away (not cleaning up), dropping any ongoing requests and give downtime / errors to the user

[sethvargo]

Looks like this is currently hardcoded, but I agree it should be configurable.

[jippi]

This is more generic, docker driver got the same problem.

Redis for example uses SIGTERM to graceful shutdown, and completely ignores SIGINT
Elasticsearch uses SIGTERM as well ( https://www.elastic.co/guide/en/elasticsearch/reference/master/stopping-elasticsearch.html )

[jippi]

Recent example(s) SIGINT is quick shutdown for nginx, where SIGQUIT will be graceful "let requests finish up" signal.

Very similar to PHP-FPM, Redis and ElasticSearch too :)

[nugend]

A tool I work with only interprets SIGTERM as "graceful" termination. It dies without invoking its cleanup procedures when it catches SIGQUIT.

Given that the template stanza is actually implementing this functionality, what's blocking this?

[yellowmegaman]

Were useful feature indeed. I'm using containerpilot, so i have preStop and postStop steps, totally depending on SIGTERM signal + graceful timeout for it to complete.

[nugend]

Could this be added to 0.6?

[dadgar]

@nugend Definitely will be in a 0.6.x release.

[TUIteamup]

@dadgar Is it confirmed that this will be in 0.6.x release? Thanks

[dadgar]

Still shooting for 0.6.X, not 0.6.0.

[nugend]

I see that 0.7 is now in the works. Is this story going to be included in that release or is it still targeted for a 0.6.X release?

[jippi]

@dadgar will this make it to 0.7 ? and is it actually possible to control for Docker containers?

[nugend]

I know that this isn't like a platform priority for you guys, but this would let me throw out some very janky shell scripting.

[nugend]

@jippi I think this can be closed now.

[github-actions]

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.