Update allocations.go #17726
Merged
Update allocations.go #17726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated missing client status "unknown" hashicorp#17688
|
|
shoenig
approved these changes
Jun 26, 2023
|
Thanks @sejalapeno! Do you mind amending the PR with a changelog entry? You can create one just by running |
|
Sure, after running |
|
Ah yeah @sejalapeno it's a little wizzard that prompts a few questions, so that it can generate the properly formatted changelog entry. This is a bug fix, so pick whichever number indicates it's for a bug fix. |
shoenig
added
backport/1.3.x
|
I hope the changes are what was required |
shoenig
reviewed
Jun 26, 2023
adding relevant desc. Co-authored-by: Seth Hoenig <shoenig@duck.com>
|
Is there anything from my end that is supposed to be done? Because the test ui workflow #2 attempt failed |
|
The UI tests are nothing to worry about here |
This was referenced Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated missing client status "unknown" #17688
Fixes #17688