Nomad service health checks urlencode the path

[sofixa]

Nomad version

Nomad v1.6.0-beta.1+ent
BuildDate 2023-06-27T16:32:15Z
Revision b26558f

Issue

A Nomad service health check configured as so:

  service {
        name = "vault-api"
        port = "http"
        provider = "nomad"
        check {
          name = "healthy"
          type = "http"
          path = "/v1/sys/health?sealedcode=200"
          interval = "10s"
          timeout  = "5s"
}

results in the path being url encoded by Nomad:
(example access log from nginx)

192.168.1.203 - - [03/Jul/2023:10:10:33 +0000] "GET /v1/sys/health%3Fsealedcode=200 HTTP/1.1" 502 157 "-" "Nomad/1.6.0-beta.1+ent (+https://www.nomadproject.io/; go1.20.5)" "-"

Which results in failing healthchecks.

Reproduction steps

Use a Nomad health check with a query string.

Expected Result

The health check should be on the path as configured.

Actual Result

URL encoded paths being used by the health check.