Consul template manager #1783
Consul template manager #1783
Conversation
dadgar
force-pushed
the
f-consul-template
branch
2 times, most recently
from
dafe298
to
e8712e7
Compare
| taskEnv *env.TaskEnvironment) (*TaskTemplateManager, error) { | ||
|
|
||
| // Check pre-conditions | ||
| if hook == nil { |
There was a problem hiding this comment.
This will miss the case of someone creating a var like var hook *MyTaskHook, never initializing it, and passing it in. It will be a non-nil interface with a nil value.
I don't think it's worth trying to guard against that case, but I thought it was worth pointing out these kinds of guards are imperfect.
There was a problem hiding this comment.
Hm, either NewTaskTemplateManager is only called from tests or its non-test callers have been trimmed from the PR.
There was a problem hiding this comment.
Yeah this just the library PR, the use of it is in the next
| Wait: &watch.Wait{}, | ||
| } | ||
|
|
||
| ctmpls[*ct] = tmpl |
There was a problem hiding this comment.
Skip the & above to skip the dereferencing here
dadgar
force-pushed
the
f-consul-template
branch
from
e8712e7
to
45531b1
Compare
dadgar
force-pushed
the
f-consul-template
branch
from
45531b1
to
1c24f59
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
No description provided.