Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid invariants documented in NetworkIndex.SetNode #17868

Open
tgross opened this issue Jul 10, 2023 · 0 comments
Open

invalid invariants documented in NetworkIndex.SetNode #17868

tgross opened this issue Jul 10, 2023 · 0 comments

Comments

@tgross
Copy link
Member

tgross commented Jul 10, 2023

While working on #16401 a while back I noticed that NetworkIndex.SetNode documents some invariants that don't seem to be true but maybe aren't necessary either. This says they need to be idempotent but they're never actually called twice on the same instance as far as I can tell.

This needs some investigation and probable refactoring when we go thru and finally clean up the old network resource structs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant